[ZKS-04] Perform garbage collection on subdag commit #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimoo
reviewed
Feb 23, 2024
|
|
||
| /// Update the storage by performing garbage collection based on the next round. | ||
| pub(crate) fn garbage_collect_certificates(&self, next_round: u64) { |
howardwu
approved these changes
Mar 3, 2024
This was referenced Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR performs garbage collection on subdag commits only. Previously we were performing GC on every round advancement, which was relying on the improbability of going 100 rounds without committing a subdag. Now we guarantee that we don't throw away older certificates in the case we do go more than MAX_GC_ROUNDS without a commit.
Note: We may also consider adding a manual skip of older certificates in the commit phase.
Audit Finding: [zksecurity 04] Garbage Collection Can Block Commits From Happening