[Fix] Update fetch redundancy as a factor of committee size #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardwu
reviewed
Mar 2, 2024
howardwu
reviewed
Mar 2, 2024
Co-authored-by: Howard Wu <9260812+howardwu@users.noreply.github.com> Signed-off-by: Raymond Chu <14917648+raychu86@users.noreply.github.com>
Co-authored-by: Howard Wu <9260812+howardwu@users.noreply.github.com> Signed-off-by: Raymond Chu <14917648+raychu86@users.noreply.github.com>
howardwu
approved these changes
Mar 3, 2024
howardwu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates the
NUM_REDUNDANT_REQUESTSto a dynamic number based on the number of validators in the committee set.The current formula for maximum allowed request redundancy is
1 + (num_validators_in_committee_lookback / 3). This can be adjusted if it is too lenient or too aggressive.Additionally, the
num_pending_requeststhat was used to measure redundancy is now adjusted to the number of sentEvent::TransmissionRequest/Event::CertificateRequest. Previously we were using the number of callbacks, which was not a good gauge of how many request messages were actually being sent out to peers.Related PRs
Related to #3135 and #3139