New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Staker requirements and BatchHeader::MAX_CERTIFICATES
#2386
Conversation
@ljedrz @niklaslong @joske There seems to be an issue with how Would you happen to have a cleaner way to do this rather than adding the cfg flags to both |
@raychu86 I usually prefer to introduce a edit: since I see that this is also in place, I would check if the crate in question is consistently imported as a |
9e055b4
to
70bf41b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a minor nit.
Co-authored-by: d0cd <23022326+d0cd@users.noreply.github.com> Signed-off-by: Raymond Chu <14917648+raychu86@users.noreply.github.com>
Signed-off-by: Raymond Chu <14917648+raychu86@users.noreply.github.com>
Signed-off-by: Raymond Chu <14917648+raychu86@users.noreply.github.com>
Motivation
This PR updates the minimum validator/delegator stakes and also the
BatchHeader::MAX_CERTIFICATES
:MIN_VALIDATOR_STAKE
: 1_000_000 credits -> 10_000_000 creditsMIN_DELEGATOR_STAKE
: 10 credits -> 10_000 creditsMAX_CERTIFICATES
: 200 -> 10Note that
Committee::MAX_COMMITTEE_SIZE
andBatchCertificate::MAX_SIGNATURES
will also be changed because they are equivalent toBatchHeader::MAX_CERTIFICATES
.