Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] snarkOS probably shouldn't count provers when trying to maintain peer connections #3011

Open
HarukaMa opened this issue Jan 16, 2024 · 2 comments
Assignees

Comments

@HarukaMa
Copy link
Contributor

HarukaMa commented Jan 16, 2024

馃挜 Proposal

Currently, the network has more provers than clients / validators. As provers don't sync with the network, it makes bootstraping and syncing hard for nodes:

  1. Most of the peers of bootstrap nodes are provers, and as bootstrap nodes currently are the only canonical block source, sometimes new blocks can't promptly propagate to other network nodes [1];
  2. If client nodes has most of their peers as provers, it will limit their view into the network and can't have many peers to sync from.

Also, as the bootstrap nodes has the same max peers as normal clients, a new node will have difficulties connecting to any one of them to do the "bootstrap" (discovering nodes). Moreover, it seems some peers of the bootstrap nodes are hardcoded internal nodes (presumably the validators run by the Aleo team), the actual max peers for them are smaller than normal client nodes.

The proposal is:

  1. Don't count provers when counting the connected peers, or count them separately so nodes could connect to more clients / validators - provers don't sync so their connections should use less resources than other peers;
  2. Increase the max peers of bootstrap nodes for now to allow more nodes to connect to them.

[1] This is also partly because we only rely on polling to sync blocks instead of broadcasting new blocks, but there are still syncing issues if a node is behind the network and need to catch up

@monu03
Copy link

monu03 commented Jan 18, 2024

this is nice

@HarukaMa
Copy link
Contributor Author

HarukaMa commented Feb 5, 2024

We now have significantly more provers than clients, so probably we should do something about this soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants