Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky networking test #80

Closed
gakonst opened this issue May 8, 2020 · 5 comments
Closed

Flaky networking test #80

gakonst opened this issue May 8, 2020 · 5 comments
Assignees
@raychu86
Labels
bug Incorrect or unexpected behavior

Comments

@gakonst
Copy link
Contributor

gakonst commented May 8, 2020 •
edited

Master currently is broken with the following error which I presume is a flaky test:

https://travis-ci.com/github/AleoHQ/snarkOS/jobs/329788277

test server_listen::startup_handshake_stored_peers ... FAILED
failures:
---- server_listen::startup_handshake_stored_peers stdout ----
thread 'server_listen::startup_handshake_stored_peers' panicked at 'called `Result::unwrap()` on an `Err` value: ConnectError(Crate("std::io", "Os { code: 104, kind: ConnectionReset, message: \"Connection reset by peer\" }"))', network/tests/server_listen.rs:198:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
    server_listen::startup_handshake_stored_peers
@gakonst gakonst added the bug Incorrect or unexpected behavior label May 8, 2020
@raychu86 raychu86 self-assigned this May 8, 2020
@raychu86
Copy link
Contributor

raychu86 commented May 9, 2020

#83

@raychu86 raychu86 closed this as completed May 9, 2020
@gakonst
Copy link
Contributor Author

gakonst commented May 13, 2020

Re-opening: https://travis-ci.com/github/AleoHQ/snarkOS/jobs/333151709

@gakonst gakonst reopened this May 13, 2020
@gakonst gakonst mentioned this issue May 13, 2020
Merged
@howardwu howardwu mentioned this issue May 16, 2020
Closed
@howardwu
Copy link
Contributor

#130

@howardwu
Copy link
Contributor

howardwu commented May 21, 2020 •
edited

I believe I've found the source of the bug. Based on our Travis CI build history, I traced back the first appearance of the flaky networking test to #52 (Travis CI log here).

It appears tokio between 0.2.14 and 0.2.18 introduces a change that causes our network test to become flaky. I will roll us back to tokio@0.2.13 while we investigate and pause Dependabot from updating it.

@howardwu howardwu mentioned this issue May 21, 2020
Merged
@gakonst
Copy link
Contributor Author

gakonst commented May 21, 2020

Confirmed that this seems to be fixed

@gakonst gakonst closed this as completed May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raychu86 raychu86

Labels
bug Incorrect or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@howardwu @raychu86 @gakonst