Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable register message spam #91

Merged
merged 3 commits into from Apr 10, 2022
Merged

Add option to disable register message spam #91

merged 3 commits into from Apr 10, 2022

Conversation

KaspianDev
Copy link
Contributor

I noticed that registering conditions causes a lot of spam in logs. So I added a config option to disable it (it sends them by default).

I also consider changing the option name to log-register but let me know if I should do that.

@AlessioGr
Copy link
Owner

@KaspianDev

Generally looks good, just a few things:

  1. Can you change the config key to "logging.verbose-startup-messages"? I think it would be a little more clear
  2. change isLoadingMessages to isVerboseLoadingMessages
  3. sometimes you have used "isDebug()" instead of "isLoadingMessages()" in the if's. Prob should be changed to isLoadingMessages as well

@AlessioGr AlessioGr merged commit e0f2d2b into AlessioGr:main Apr 10, 2022
@AlessioGr
Copy link
Owner

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants