New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option for inserting smiley markup #323
Comments
Idk. Maybe on the color plugin base, changing colors squares by smileys and by calling |
any progress on this? i'm interested as well! |
Not sure right now. I am planning to do it like Facebook, let the users use markup like :) or :( in the text, then at the time of getting the HTML and pasting ti back, parse through such markups, convert them to respective inline images and render alongwith the rest of the content. |
Sounds good! I'm currently looking in a implemenation with at.js |
Hi, |
@NicolasPion this is how it works wit my At.js implementation right now, but i like yours better: best regards |
You can PR them in two plugins :) |
@NicolasPion There is an issue with the scroll bar in the emoji dropdown. Testing in: Using version 2.3.0 but I replicated this issue in 2.4.2 You can't click on the emoji scroll bar. When you do so, the emoji dropdown goes away. I believe this is happening because the dropdown as a whole has a close on click event attached to it. But that affects the scroll bar. The emojis themselves probably need a container separate from the dropdown container. I tried to track down where this is done in you code but I couldn't. If you point me in the right direction, maybe I can fix it. Thanks. Thanks. |
Hi @muyiwaoyeniyi , i think it's not emoji plugin related (you can reproduce this issue with the "color" plugins for exemple, if you dont click on a color icon but you click inside the dropdown.. in a "white" area) but this PR can resolve that 😈 : #459 |
@NicolasPion Thanks for the response and PR.. Yea I didnt try out the color plugin. But good to know. All the best. |
Merged :) |
Helo, i have done the emojifyjs : plugin, i get smileys, with text, but how to get the images inside the div?? |
@danman1234, you can add something like :
|
This works, but as before too sometimes it shows the smiley ico and othertimes not. If i refeesh 4 times, then the smiley ico will show up.
but then it never shows up anymore. |
@danman1234 try this PR (not yet merged) : #548 |
hey @graphek : possible to share your at.js implementation please ? :) |
@Ydalb Sorry, i dont have the code for the smilies anymore because i liked the toolbar-version more. But i still use At.js for @mentions like this: ` // @MENTIONS
Insert after initialization of trumbowyg best regards |
Nevermind @graphek , I also implemented the toolbar-version :D But I also use at.js for mentions, love it ❤️ |
I want to give an additional button for inserting smileys. When user clicks the button, a popup is shown nearby displaying some 30 smiley icons, clicking any of which inserts that into the caret position.
How do I add this button and the functionality here?
The text was updated successfully, but these errors were encountered: