Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight plugin doesnt recognize all syntaxes #776

Closed
pavelloz opened this issue May 1, 2018 · 1 comment
Closed

Highlight plugin doesnt recognize all syntaxes #776

pavelloz opened this issue May 1, 2018 · 1 comment
Labels
enhancement request plugin Non-core related things

Comments

@pavelloz
Copy link

pavelloz commented May 1, 2018

if (Prism.languages[lang].comment) {

This condition is not met for all syntaxes, ie. liquid.
https://github.com/PrismJS/prism/blob/gh-pages/components/prism-liquid.js

Is it something important? I cant figure why comment should be obligatory in a syntax (or rather, any truthy value under the key) to be visible in the code highlight dropdown.

@Alex-D
Copy link
Owner

Alex-D commented May 2, 2018

Idk, that's from a contributor.

If you want you can make a Pull Request to change that if it works without this condition.

@Alex-D Alex-D added enhancement request plugin Non-core related things labels May 2, 2018
@Alex-D Alex-D closed this as completed in 5a77bcb Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement request plugin Non-core related things
Projects
None yet
Development

No branches or pull requests

2 participants