Added callback for getting breadcrumbs from navigation #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added in release 1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on adding tracing and performance analytics to the app. Right now Odyssey provides one way to monitor transactions.
RootController.currentScreenoutputs updates related to shown and removed screens. Unfortunately, this flow doesn't emit stream of events which correspond to screen changes one-to-one.This PR adds new callback which can be used by the app to monitor screen changes. It filters some event sources and helps with nested navigation (e.g. bottom navigation tabs switching emits both tab name and owner screen name).
Unfortunately, this doesn't cover multiple layers of nesting (like bottom navigation where the screen also has tabs). Also, I'm not 100% sure on the format of the data.
Could you please check the general direction of this change? Are there any caveats I should know, or maybe you have some different takes on solving this?