Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.0-rc.0 does not work with rxjs6 #45

Closed
zorrme opened this issue Apr 29, 2018 · 10 comments
Closed

v5.0.0-rc.0 does not work with rxjs6 #45

zorrme opened this issue Apr 29, 2018 · 10 comments
Labels

Comments

@zorrme
Copy link

zorrme commented Apr 29, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request

Current behavior

v5.0.0-rc.0 does not work with rxjs6

Expected behavior

Minimal reproduction of the problem with instructions

Environment


Angular version: X.Y.Z
ngx-permissions version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
@AlexKhymenko
Copy link
Owner

@zorrme have You installed rxjs-compat also?

@zorrme
Copy link
Author

zorrme commented Apr 29, 2018

yes, I was wondering whether you published from the right branch ?

@AlexKhymenko
Copy link
Owner

@zorrme Yes :-) i have tested it worked. Can You please specify your environment and what error do You have?

@zorrme
Copy link
Author

zorrme commented Apr 29, 2018

I am using "@angular/cli": "^6.0.0-rc.7", rxjs 6, rxjs-compat 6, and angular ^6.0.0-rc.6.
The problem is I am using ngxPermissionsExcept directive, but looks the permissions is not getting populated.

@AlexKhymenko
Copy link
Owner

Thank You. Will recheck everything for now dont use new version.

@zorrme
Copy link
Author

zorrme commented Apr 29, 2018

Also, can you please provide a sample app if api has changed ?

@AlexKhymenko
Copy link
Owner

AlexKhymenko commented Apr 29, 2018

I'm not planning on changing api(and i didn't change any api). Im working on restoring all infrastructure(plunker). Tested with angular 5 it worked right now building new project with latest angular cli and angular will test it.

@AlexKhymenko
Copy link
Owner

AlexKhymenko commented Apr 29, 2018

@zorrme i have tested with latest angular and it worked. Can You paste snippet how you define permission will be very helpfull

@zorrme
Copy link
Author

zorrme commented Apr 29, 2018

My bad, the code to populate the permissions was commented. It is all good now, thanks.

@zorrme zorrme closed this as completed Apr 29, 2018
@AlexKhymenko
Copy link
Owner

AlexKhymenko commented Apr 29, 2018

:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants