Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change Video URL on top (first video) + fix share button for it #156

Open
MichaelKohler opened this issue Nov 6, 2014 · 8 comments
Open

change Video URL on top (first video) + fix share button for it #156

MichaelKohler opened this issue Nov 6, 2014 · 8 comments
Labels
blocker-phase3 needs-more-information

Comments

@MichaelKohler
Copy link
Collaborator

Jessica or TJ, what's the correct link to use here?

also, we need to decouple the share button from the share button of the second video, since the URL is different
@MichaelKohler
Copy link
Collaborator Author

link will come tomorrow, this will be another video than on the bottom of the page in the "offline" section

@tripad
Copy link
Contributor

tripad commented Nov 7, 2014

what about "share this page" button(s) ?

@MichaelKohler MichaelKohler self-assigned this Nov 7, 2014
@MichaelKohler
Copy link
Collaborator Author

this is done locally, can't push this to the repo though because we don't want to destroy the surprise :)

@MichaelKohler
Copy link
Collaborator Author

well, I still need to change the URLs for other languages, but it's basically done

@MichaelKohler
Copy link
Collaborator Author

still missing: "use this code" .. working on it

@lcamacho lcamacho mentioned this issue Nov 8, 2014
Closed
@MichaelKohler
Copy link
Collaborator Author

added tracking to the first video's share button, will push that at given time too.

@MichaelKohler
Copy link
Collaborator Author

also the Share button works (obviously didn't test it 100% through since I can't share it right now :))

@MichaelKohler
Copy link
Collaborator Author

left blocker: Links to the videos

@MichaelKohler MichaelKohler removed their assignment Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker-phase3 needs-more-information
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelKohler @tripad