Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo configs from https://getscaffold.dev/ #17

Closed
AlexSkrypnyk opened this issue Sep 12, 2023 · 2 comments
Closed

Update repo configs from https://getscaffold.dev/ #17

AlexSkrypnyk opened this issue Sep 12, 2023 · 2 comments

Comments

@AlexSkrypnyk
Copy link
Owner

AlexSkrypnyk commented Sep 12, 2023

Download the latest code from Scaffold repo (actual code, not the release).

  • Update composer.json with the structure from Scaffold. Preserve the values of the existing fields, but order the fields as per Scaffold's composer.json. Add missing fields.

  • Update the Symfony command to use the file structure of CLI Command from the scaffold repo.

  • Update tests to use new traits from Scaffold instead of a HelperTrait.php. Use only traits that are required.

  • Update CI to run with coverage

  • Add Renovate config from Scaffold

  • Add/update all GitHub actions and configs to be per Scaffold

  • Update readme to use the structure from Scaffold, including the generated logo (circle). Transfer the usage examples into the readme structure from Scaffold

  • Update Box config

  • Add PHPStan config and fix all newly found violations

  • Do not create docs folder and CI action - this project is too small to have extensive docs.

Make sure that CI passes.

@lankmiler
Copy link
Contributor

@AlexSkrypnyk Can you explain more about 2 point. Or give maybe some kind of example. And also there is a lot of issues related to phpstan(185), do we need to fix them all?

@AlexSkrypnyk
Copy link
Owner Author

@lankmiler
Re 2 - please see https://getscaffold.dev/php/cli-command.html

just need to update the code structure to reflect what is in the scaffold - the command loader , app loader, src, tests

re phpstan - please fix all violations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants