remove unnecssary execute #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexTrotsenko would you be able to pull this in and publish? We're trying to push a build and unable to include J2V8 Debugger without this fix. |
|
Hi @jamie-houston thanks for pinging me, I will take care of it tomorrow |
|
@jamie-houston please have a look at my minor clean-up commit. P.S. if you would like to - you can squash all these 3 commits |
|
In order to speed-up publishing I have already added |
|
@AlexTrotsenko looks good. Thanks! |
|
@jamie-houston merged and pushed new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8Executor.execute was unnecessary here as this is only setting references, not calling v8. This was causing an issue depending on when bindV8ToChromeDebuggerIfReady was called.