Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bioconda package #7

Open
loraine-gueguen opened this issue Mar 11, 2022 · 13 comments
Open

Bioconda package #7

loraine-gueguen opened this issue Mar 11, 2022 · 13 comments

Comments

@loraine-gueguen
Copy link
Contributor

Hi,

I work on the bioinformatics platform ABiMS in Roscoff, France.

We are interested in your tool RREFinder. To follow our installation policies (we use Conda env), I would like to add your tool as a package on the bioconda channel. I started a PR here: bioconda/bioconda-recipes#33650

But for that, I miss a release of the tool with a version number and a tar.gz archive. Would it be possible to tag a release in your Github repo ?

Also feel free to push commits or comment in the PR !

Regards,

Loraine Guéguen

@loraine-gueguen
Copy link
Contributor Author

I submitted a PR to add a setup.py script also needed to build the conda package: #8

@Alexamk
Copy link
Owner

Alexamk commented Mar 21, 2022

Hi! Nice to hear you're interested in using this tool and sorry for the late reply. I'll have a look at the pull request tomorrow. Can I ask if you intend to use just precision mode (relying only on HMMs) or also exploratory mode? The latter relies on several databases, and I'm not sure those could be included directly in the conda package.

@Alexamk
Copy link
Owner

Alexamk commented Mar 22, 2022

Hello again. I've merged the setup file after adding some additional information. I've also made some updates to the script to hopefully make it easier to install the full functionality of the tool (it relies on some parts that are not on conda).

I'm not experienced in building conda packages though. What else would be required?

@loraine-gueguen
Copy link
Contributor Author

loraine-gueguen commented Mar 22, 2022

Thanks! I have contacted the users to ask them if they need the precision mode or the exploratory mode. I don't know yet.

What else would be required?

Bioconda also needs a release of the tool with a version number and a tar.gz archive. Would it be possible to tag a release in your Github repo ?

@Alexamk
Copy link
Owner

Alexamk commented Mar 23, 2022

Bioconda also needs a release of the tool with a version number and a tar.gz archive. Would it be possible to tag a release in your Github repo ?

Done.

@loraine-gueguen
Copy link
Contributor Author

Thanks for the release! I will update the bioconda recipe : bioconda/bioconda-recipes#33650
BTW, the users have answered and are interested in the exploratory mode.

@Alexamk
Copy link
Owner

Alexamk commented Mar 24, 2022

Sounds good. A small disclaimer for exploratory mode: it relies on scripts that are part of the HHSuite package, but not officially supported. See soedinglab/hh-suite#254.
I added some scripts to enable their usage for RREFinder. Hopefully they would work as well when RREFinder is installed through Conda. We'll have to see when it is available.

@loraine-gueguen
Copy link
Contributor Author

loraine-gueguen commented Mar 24, 2022

I also need to add the about/license key in the meta.yml file for conda.
Do you want to add a license to your github repo ? Otherwise I can tell "no license".

@loraine-gueguen
Copy link
Contributor Author

The license is a requirement, to allow redistribution of the software within bioconda. Could you please add one @Alexamk ?

@Alexamk
Copy link
Owner

Alexamk commented Mar 28, 2022

A license has been added.

@loraine-gueguen
Copy link
Contributor Author

thanks

@loraine-gueguen
Copy link
Contributor Author

FYI: one last limiting point but which does not depend on you: we cannot use the psipred dependency from the channel conda biocore... I opened an issue on the biocore/conda-recipes gihub repo to ask them if they can migrate to bioconda, which they intended to do a few years ago.

@loraine-gueguen
Copy link
Contributor Author

Update : without any answer from the biocore/conda-recipes gihub repo regarding the migration of psipred to bioconda, I have chosen to comment the dependency in the RREfinder conda recipe and add a post-link message : bioconda/bioconda-recipes@70b9d49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants