-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ArangoDB API #6
Comments
...thinking about picking up support for this. :) |
that would be amazing... have you made some progress? |
Hey, seems like a commit for an Arangojs v6 update has been done - see carlitux/connect-arango@master...antioxidanz:master. 5 years since a publish to Npm - time to ask if the project is being maintained? |
@jeffvandyke thx for the post, I'm not sure if the changes he made would change the compatibility, because what I can see by now is, that he changed the description, all vars to let and added got rid of the url and replaced it through variables (which is a good). Have you tested it? edit: just saw, that he used then the new api as well... @AlexanderArvidsson I haven't created a pull-request, because it changes in your readme the npm install... do you like to update your version? |
Looks like it's already working? |
I haven't tested it, but I do have a side project that uses session with MemoryStore, and ArangoDB, and could bring an updated version there, if it's helpful and if I get around to it. |
Currently maintained repo: https://github.com/ryanking1809/connect-arango |
@imsys If you wish to submit a pull request to this repository I can approve it and publish, but I will not have time to test any changes since I have not used Arango for 7 years lol. |
I think we should try to improve the Bus factor of the project. We could add more collaborators to the repo (It's in Settings -> Manage Access) or create an Organization and put the repo under it. The ones who have done the most fixes in other forks are @carlitux and @ryanking1809, maybe they could help being collaborators, or at least manage pull requests. Their changes: master...ryanking1809:master But for now I will just take @ryanking1809 fork and change his README file to point the installation to using npmjs, and then create the PR. |
I don't have a lot of time to be a maintainer but I do plan on using this in production in a few months so am happy to help out where I can. I forked @antioxidanz when updating to arangojs 7.5 if they're interested. |
Great idea! I will add anyone who feels like they want to contribute to maintain this package. |
This whole package is really outdated though. We should switch to using TypeScript. The codebase is small enough that this would be a trivial task. Also introduce a version management system like Lerna. If only I had time, I would do it myself haha :) |
I have now published 0.2.0 to NPM. Would be great if someone tested it out for me!. |
@AlexanderArvidsson sorry I somehow missed your message. Happy to be a contributor. The package is working fine for me. |
@ryanking1809 I've invited you as a collaborator to the repo! |
Is not compatible with current arangoJS. Just works with 2.3.x
The text was updated successfully, but these errors were encountered: