Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ArangoDB API #6

Open
me89 opened this issue Mar 10, 2019 · 15 comments
Open

Update ArangoDB API #6

me89 opened this issue Mar 10, 2019 · 15 comments

Comments

@me89
Copy link

me89 commented Mar 10, 2019

Is not compatible with current arangoJS. Just works with 2.3.x

@armenr
Copy link

armenr commented Apr 13, 2019

...thinking about picking up support for this. :)

@me89
Copy link
Author

me89 commented Jun 6, 2019

that would be amazing... have you made some progress?

@jeffvandyke
Copy link

jeffvandyke commented Aug 13, 2019

Hey, seems like a commit for an Arangojs v6 update has been done - see carlitux/connect-arango@master...antioxidanz:master. 5 years since a publish to Npm - time to ask if the project is being maintained?

@me89
Copy link
Author

me89 commented Aug 21, 2019

@jeffvandyke thx for the post, I'm not sure if the changes he made would change the compatibility, because what I can see by now is, that he changed the description, all vars to let and added got rid of the url and replaced it through variables (which is a good). Have you tested it?

edit: just saw, that he used then the new api as well... @AlexanderArvidsson I haven't created a pull-request, because it changes in your readme the npm install... do you like to update your version?

@armenr
Copy link

armenr commented Aug 22, 2019

Looks like it's already working?

@jeffvandyke
Copy link

I haven't tested it, but I do have a side project that uses session with MemoryStore, and ArangoDB, and could bring an updated version there, if it's helpful and if I get around to it.

@imsys
Copy link
Contributor

imsys commented Nov 20, 2021

Currently maintained repo: https://github.com/ryanking1809/connect-arango

@AlexanderArvidsson
Copy link
Owner

AlexanderArvidsson commented Nov 23, 2021

@imsys If you wish to submit a pull request to this repository I can approve it and publish, but I will not have time to test any changes since I have not used Arango for 7 years lol.

@imsys
Copy link
Contributor

imsys commented Nov 23, 2021

I think we should try to improve the Bus factor of the project. We could add more collaborators to the repo (It's in Settings -> Manage Access) or create an Organization and put the repo under it. The ones who have done the most fixes in other forks are @carlitux and @ryanking1809, maybe they could help being collaborators, or at least manage pull requests.

Their changes: master...ryanking1809:master

But for now I will just take @ryanking1809 fork and change his README file to point the installation to using npmjs, and then create the PR.

@ryanking1809
Copy link
Collaborator

ryanking1809 commented Nov 23, 2021

I don't have a lot of time to be a maintainer but I do plan on using this in production in a few months so am happy to help out where I can. I forked @antioxidanz when updating to arangojs 7.5 if they're interested.

@AlexanderArvidsson
Copy link
Owner

I think we should try to improve the Bus factor of the project. We could add more collaborators to the repo (It's in Settings -> Manage Access) or create an Organization and put the repo under it. The ones who have done the most fixes in other forks are @carlitux and @ryanking1809, maybe they could help being collaborators, or at least manage pull requests.

Their changes: master...ryanking1809:master

But for now I will just take @ryanking1809 fork and change his README file to point the installation to using npmjs, and then create the PR.

Great idea! I will add anyone who feels like they want to contribute to maintain this package.
Any PRs are also welcome but I unfortunately do not have the possibility to test any of them since I have no projects using ArangoDB currently and have no time to set one up.
@carlitux, @ryanking1809 and @imsys, do you wish to be added as a contributor to this project?

@AlexanderArvidsson
Copy link
Owner

This whole package is really outdated though. We should switch to using TypeScript. The codebase is small enough that this would be a trivial task. Also introduce a version management system like Lerna. If only I had time, I would do it myself haha :)

@AlexanderArvidsson
Copy link
Owner

I have now published 0.2.0 to NPM. Would be great if someone tested it out for me!.

@ryanking1809
Copy link
Collaborator

ryanking1809 commented Jan 17, 2022

@AlexanderArvidsson sorry I somehow missed your message. Happy to be a contributor.
I'll probably just ensure it runs on the latest arangojs for the time being.

The package is working fine for me.

@AlexanderArvidsson
Copy link
Owner

@ryanking1809 I've invited you as a collaborator to the repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants