Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck value is unnecessary #17

Merged
merged 2 commits into from Feb 20, 2018

Conversation

joeyvandijk
Copy link
Contributor

You check for tracing value and not healthcheck > tracing in your code, so removing healthcheck fixes the example.

You check for `tracing` value and not `healthcheck` > `tracing` in your code, so removing `healthcheck` fixes the example.
@alex-murashkin
Copy link
Owner

Yeah, the purpose was to demonstrate the override option, and healthcheck is just an example lambda function that overrides the provider's "true" setting.

If the docs aren't clear, possibly, how about we rename healthcheck to overrideExampleFunction?

@joeyvandijk
Copy link
Contributor Author

joeyvandijk commented Feb 16, 2018

Perhaps it is better to be consistent, so healthCheckFunction? see code.

@alex-murashkin alex-murashkin merged commit 9b86435 into alex-murashkin:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants