Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"compatible version" specifier in setup.py confuses poetry #81

Closed
burnpanck opened this issue Mar 16, 2023 · 2 comments
Closed

"compatible version" specifier in setup.py confuses poetry #81

burnpanck opened this issue Mar 16, 2023 · 2 comments
Labels
invalid This doesn't seem right

Comments

@burnpanck
Copy link

The documentation and the "Classifiers" inside setup.py seem to indicate that portion is supposed to support python 3.7 and up.

However, setup.py also specifies python_requires="~=3.7", which, according to canonical SemVer (or node.js really) only allows patch-level upgrades. PEP440 on the other hand says it is equivalent to >=3.7,==3.* which I believe is what you intend. Unfortunately, it seems that poetry currently misinterprets that specification.

Given that the two specifications differ in their interpretation of the ~= specification, it may be wise to simply use >=3.7,==3.* directly. Explicit is better than implicit.

@burnpanck
Copy link
Author

My bad, I misinterpreted poetry's output.

@AlexandreDecan
Copy link
Owner

I like self-resolving issues ;-)

@AlexandreDecan AlexandreDecan added the invalid This doesn't seem right label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants