Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in qt5 testcase.prf #1117

Open
nullmedium opened this issue Jan 26, 2018 · 2 comments
Open

Bug in qt5 testcase.prf #1117

nullmedium opened this issue Jan 26, 2018 · 2 comments

Comments

@nullmedium
Copy link

A patch that is applied to qt5 testcase.prf breaks the "check" target.

The use of $$system_path for $$TESTRUN_CWD creates a Windows style path. If the target
is executed within the msys shell, the windows style path doesn't work when changing to the testcase directory.

@ossilator
Copy link

yes, system_path() is bogus; it must be shell_path() here.

see also https://codereview.qt-project.org/217175 ; i'd expect 5.9 HEAD to work out of the box with msys now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants