Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False claims about accessibility. #21

Closed
matuzo opened this issue Mar 13, 2023 · 3 comments
Closed

False claims about accessibility. #21

matuzo opened this issue Mar 13, 2023 · 3 comments

Comments

@matuzo
Copy link

matuzo commented Mar 13, 2023

Hi,

the sentence "Our goal is to ensure the toggles remain as accessible as possible. This includes proper screen reader support." on your about page suggests that the examples on your website are accessible. Unfortunately, that's not the case. All of the examples are either inaccessible with the keyboard, a screen reader or both.
Since it took me only 5 seconds to learn that, I have to assume that accessibility or, at least, accessibility testing in fact isn't your top priority. That's fine, given that this is a OS project you maintain in your spare time, but claiming that accessibility is "your goal" is misleading, especially for people who don't know how to test for accessibility and trust authors like you.

Please consider removing the misleading statements about accessibility until you or someone else fixes the issues. If you need help with that, feel free to get in touch.

Thank you.

@mikemai2awesome
Copy link

Second the above, and please do not encourage people to use <div> as buttons. If one chooses to use <div>, they would have to make sure proper aria attributes are applied, and custom JavaScript is written to replicate everything that a semantic button does. Your code snippets do not reflect this important piece of information.

@AlfieJones
Copy link
Owner

AlfieJones commented Mar 13, 2023

Thanks for the feedback 👍. I've gone ahead and removed the aforementioned statements.

The issues described above are with the checkbox element, the button works better (although still has room for improvement).

I have created a new issue here to tack/give feedback on the new version #22
It has a link to a storybook where you can try out the new version of the toggles, any help on improving the accessibility is greatly welcomed

@AlfieJones
Copy link
Owner

Second the above, and please do not encourage people to use <div> as buttons. If one chooses to use <div>, they would have to make sure proper aria attributes are applied, and custom JavaScript is written to replicate everything that a semantic button does. Your code snippets do not reflect this important piece of information.

I will be doing this in the new documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants