-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Linux Xfce4 #12
Comments
I've created the pull request for this: #13 |
Definitely, I'll look into it or if you want - you're welcome to try and add support for it and submit a pull request. |
Please take a look at the pull request: #13 |
Awesome, sorry for the wait, I'll take a look at it. |
So I tested it on Xfce 4.14 and it didn't work for me. The good thing is that I know why. Your current logic assumes that the property to set the wallpaper is that which contains
However, when I tried it, that was not the case for my system (tested using Linux mint 19.3). Monitoring Xfce for changes I noticed that the property used for setting the wallpaper for me was
and there were a few other properties that contained To be more specific, the current logic is using the following property to set the wallpaper on my system which does not change the wallpaper:
So, the logic needs to be updated so that it works with other configurations before It can be merged. The tricky part is figuring out how to distinguish between configurations so that Venus knows the property to set the image with since I suspect that it will be different based on versions of Xfce4 and monitor setups (currently only accounting for single monitor setups of course). I'll leave the logic up to you, but maybe looking at log files to see how the last image was set could work. |
Hi, support for the Linux desktop environment Xfce4 is missing. Can we add it?
The text was updated successfully, but these errors were encountered: