Rely on action to create npmrc (#1542)

* Rely on action to create npmrc * Fix url for npm
Alfresco · Mar 6, 2023 · d697c76 · d697c76
1 parent 3dea8b1
commit d697c76
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/.github/workflows/js-api-build.yml b/.github/workflows/js-api-build.yml
@@ -17,7 +17,7 @@ env:
     GITHUB_PULL_REQUEST: ${{ github.event.number }}
     GITHUB_BUILD_NUMBER: ${{ github.run_number }}
     NPM_REGISTRY_TOKEN: ${{ secrets.NPM_REGISTRY_TOKEN }}
-    NPM_REGISTRY_ADDRESS: ${{ secrets.NPM_REGISTRY_ADDRESS }}
+    NPM_REGISTRY_ADDRESS: ${{ vars.NPM_REGISTRY_ADDRESS }}
 
 jobs:
     build:
@@ -123,9 +123,9 @@ jobs:
               if: github.ref == 'refs/heads/master' || github.ref == 'refs/heads/develop'
               with:
                 node-version: 16
-                registry-url: $NPM_REGISTRY_ADDRESS
+                registry-url: 'https://${NPM_REGISTRY_ADDRESS}'
                 scope: '@alfresco'
-            - run: ./scripts/publish.sh nx affected --target=npm-publish $NX_CALCULATION_FLAGS --tag=$TAG_NPM || exit 1
+            - run: ./scripts/publish.sh
               env:
                 NODE_AUTH_TOKEN: $NPM_REGISTRY_TOKEN
 

diff --git a/scripts/publish.sh b/scripts/publish.sh
@@ -12,14 +12,8 @@ fi
 
 cd dist/
 
-echo "Publishing on npm with tag $TAG_NPM"
-
-touch .npmrc
-echo 'strict-ssl=true' >>.npmrc
-echo 'registry=https://${NPM_REGISTRY_ADDRESS}' >>.npmrc
-echo '//${NPM_REGISTRY_ADDRESS}/:_authToken="${NPM_REGISTRY_TOKEN}"' >>.npmrc
+echo "Publishing on npm registry: ${NPM_REGISTRY_ADDRESS} with tag $TAG_NPM"
 
 cat package.json | grep version
 
 npm publish --tag ${TAG_NPM} || exit 1
-rm -rf .npmrc