Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

[ADF-1200] Error handling for wrong host urls #256

Merged
merged 2 commits into from
Jul 26, 2017

Conversation

popovicsandras
Copy link
Contributor

Please check if the PR fulfills these requirements

[x] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-js-ap/wiki/Commit-format)
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
See ticket ADF-978 and ADF-1200

What is the new behavior?
In case of wrong urls, we handle the errors properly.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Jul 26, 2017

Codecov Report

Merging #256 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #256   +/-   ##
============================================
  Coverage        87.07%   87.07%           
============================================
  Files               25       25           
  Lines             1021     1021           
  Branches           190      190           
============================================
  Hits               889      889           
  Misses             132      132
Impacted Files Coverage Δ
src/ecmAuth.js 97.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d44f0e3...f8de556. Read the comment docs.

@eromano eromano merged commit f56c9e7 into development Jul 26, 2017
@eromano eromano mentioned this pull request Jul 31, 2017
eromano pushed a commit that referenced this pull request Jul 31, 2017
* login and ticket creation fixes

* Update changelog
eromano added a commit that referenced this pull request Aug 1, 2017
* [ADF-622] Complete TypeScript definitions for JS-API (#236)

* new definition for core

* move to node 8

* change log update

* update typescript 2.4.0

* [ADF-793] The ability to retrieve a rendition's url from the content API (#238)

* add getRenditionUrl method

* [ADF-793] getRenditionUrl

* CHANGELOG update

* Update CHANGELOG.md

* updating declarations (#239)

* fix constructor probpme d.ts

* Fixing tslint error (#241)

* index.d.ts fix tslint (#242)

* update typings

* Added isRelatedContent option to create related content on process in… (#243)

* Added isRelatedContent option to create related content on process instance

* Fix error on createRelated content - added change to changelog

* Update CHANGELOG.md

* APS ContentApi is not present on index.d.ts and SitesApi is not complete (#251)

* fix upload index.d.ts

* [ADF-1086] content api improvements (#254)

* content api improvements

* update type definitions

* update changelog

* Add audit task log endpoints (#255)

-getTaskAuditJson
-getTaskAuditPdf

* [ADF-1200] Error handling for wrong host urls (#256)

* login and ticket creation fixes

* Update changelog

* [ADF-1199] MinimalNodeEntryEntity is missing the "allowableOperations" property

* 1.7.0
eromano pushed a commit that referenced this pull request Sep 5, 2017
* login and ticket creation fixes

* Update changelog
@DenysVuika DenysVuika deleted the dev-apopovics-ADF-1200 branch September 15, 2017 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants