Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Unzippedxxxx.txt files #8

Closed
Sandalorian opened this issue Nov 12, 2019 · 2 comments
Closed

Clean up Unzippedxxxx.txt files #8

Sandalorian opened this issue Nov 12, 2019 · 2 comments
Assignees
@Sandalorian
Labels
bug

Comments

@Sandalorian
Copy link
Contributor

After implementing #6 if you open multiple jmx dumps one after another in the same window, you end up with multiple extracted unzippedxxx.txt files in your target directory:

image
@Sandalorian Sandalorian self-assigned this Nov 12, 2019
@Sandalorian
Copy link
Contributor Author

expose zip file as a class variable, set when extracting zip, then delete file on close

@Sandalorian Sandalorian mentioned this issue Nov 15, 2019
Open
@Sandalorian
Copy link
Contributor Author

fixed (somewhat) via commit:

864b298

and

ef63e4b

But need to note #11

Closing as #11 only happens in very limited circumstances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sandalorian Sandalorian

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sandalorian