Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getproperty type piracy #382

Closed
mohamed82008 opened this issue Feb 6, 2021 · 2 comments · Fixed by #383
Closed

getproperty type piracy #382

mohamed82008 opened this issue Feb 6, 2021 · 2 comments · Fixed by #383
Assignees
Labels

Comments

@mohamed82008
Copy link

mohamed82008 commented Feb 6, 2021

Hi,

I would like to draw your attention to a type piracy that Catlab has in its definition of getproperty. This is causing a slowdown in surprising ways in Julia. Ref: JuliaLang/julia#39534

@epatters
Copy link
Member

epatters commented Feb 6, 2021

Thanks for reporting this. We'll look into fixing it.

I did not actually realize that this counts as type piracy, but if it's causing problems, it should be fixed.

@epatters epatters added the bug label Feb 6, 2021
@epatters
Copy link
Member

epatters commented Feb 8, 2021

@olynch, we should address this. I suggest that we just eliminate the getproperty overrides for C-set types and replace them with accessor functions, e.g., CD.ob would become ob(CD). Definitely no type piracy there since we own those functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants