Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove acset transformation type parameters kept for backward compatibility #755

Closed
epatters opened this issue Mar 27, 2023 · 0 comments · Fixed by #795
Closed

Remove acset transformation type parameters kept for backward compatibility #755

epatters opened this issue Mar 27, 2023 · 0 comments · Fixed by #795
Assignees
@epatters
Labels
acsets cleanup

Comments

@epatters
Copy link
Member

In #754, we reintroduced two type parameters, S and Comp, for the abstract type ACSetTransformation to restore backwards compatibility. However, these only make sense for struct acset transformations (and the second one really shouldn't be there at all). They should be removed in the next breaking release.

The two other type parameters, Dom and Codom, can be kept.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epatters epatters

Labels
acsets cleanup
Projects
No open projects
Catlab v0.15
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove acset transformation type parameters kept for backward compatibility epatters/Catlab.jl
1 participant
@epatters