Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR decomposition for Least-Squares in LLS sharp #89

Closed
jpfairbanks opened this issue May 22, 2024 · 0 comments · Fixed by #90
Closed

QR decomposition for Least-Squares in LLS sharp #89

jpfairbanks opened this issue May 22, 2024 · 0 comments · Fixed by #90

Comments

@jpfairbanks
Copy link
Member

In the definition of the sharp matrix for LLSDDSharp:
https://github.com/AlgebraicJulia/CombinatorialSpaces.jl/blob/main/src/DiscreteExteriorCalculus.jl#L781

There is a pinv(X'X)

This should be replaced by a QR decomposition of Q. Ideally, we would do an implicit solve with Rx = Q'b but since you want to realize a matrix for this, you could at least take the reduced inv(R)*Q'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant