Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] added google-auth #44

Merged
merged 3 commits into from Apr 2, 2021
Merged

[FEATURE] added google-auth #44

merged 3 commits into from Apr 2, 2021

Conversation

aditya201551
Copy link
Contributor

Related Issue

  • Added a feature for users to login with their google account

Closes: #33

Describe the changes you've made

  • Added social-auth setup in settings.py
  • Registered templates
  • Added index.html to use login/logout feature

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@diyajaiswal11

@harsh7in
Copy link
Collaborator

harsh7in commented Apr 1, 2021

@aditya201551 can you plz add screenshots.

@harsh7in
Copy link
Collaborator

harsh7in commented Apr 1, 2021

as I am getting an error on http://127.0.0.1:8000/accounts/google/login/ this route.

@aditya201551
Copy link
Contributor Author

@harsh-9in I have made all the changes but I forgot that db.sqlite3 has been added to .gitignore so I will update this db file and then add it to this pr you will get the update commit within an hr and remaining all the changes done to the project will remain the same. Thank You

@aditya201551
Copy link
Contributor Author

@harsh-9in i have updated the branch with required changes

Copy link
Collaborator

@harsh7in harsh7in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Features are working fine. LGTM 👍

@aditya201551
Copy link
Contributor Author

@harsh-9in great thanks!

@harsh7in harsh7in added GSSOC21 To be counted for GSSoC'21 Level2 Level2 for GSSOC21 labels Apr 1, 2021
@harsh7in harsh7in merged commit 97800c7 into Algo-Phantoms:main Apr 2, 2021
@aditya201551 aditya201551 deleted the social-auth branch April 2, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSOC21 To be counted for GSSoC'21 Level2 Level2 for GSSOC21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] [GSSOC 2021] Adding user login and authentication with google: Login and Logout feature
2 participants