Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persian number option #1

Closed
DanialV opened this issue Jan 16, 2019 · 8 comments
Closed

Add persian number option #1

DanialV opened this issue Jan 16, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DanialV
Copy link

DanialV commented Jan 16, 2019

It would be great if you create a feature for supporting Persian number in date picker because this is a Persian date picker with numbers should be in a Persian format not English.

@Ali-Azmoud
Copy link
Owner

Ali-Azmoud commented Jan 16, 2019

Hi
Yeah you're right. at first, I was up to add this feature, but later I realized it would be better if user can change the whole font of datepicker so that numbers and other parts can change to farsi or any other style,

I'm going to add this feature ( changing font ) soon, after that I will start working on on farsi numbers without changing font.

I believe 'Vazir' is a great persian font which supports Farsi numbers as well.
here is the link, its free

@Ali-Azmoud Ali-Azmoud added the enhancement New feature or request label Jan 16, 2019
@Ali-Azmoud Ali-Azmoud self-assigned this Jan 16, 2019
@Ali-Azmoud
Copy link
Owner

in the latest version you can use farsiDigits to get persian numbers

also you can change font family by fontFamily if you have a font supports persian numbers

@DanialV
Copy link
Author

DanialV commented Jan 17, 2019

great thanks so much for the awesome support
By the way, I couldn't see your source code in your repo, is your library closed source I would like to contribute to it and add some cool feature in future if possible.

@DanialV
Copy link
Author

DanialV commented Jan 17, 2019

I tested new version still something is missing output date which is shown in the text field is still English number I tried onChanged property in order to convert it my self however your library doesn't trigger onChanged property when the date changed.

@Ali-Azmoud
Copy link
Owner

Ali-Azmoud commented Jan 17, 2019

I tested new version still something is missing output date which is shown in the text field is still English number I tried onChanged property in order to convert it my self however your library doesn't trigger onChanged property when the date changed.

I don't think that gonna work. Farsi numbers are not real number characters, and they don't have number functionalities. it will fail I'm sure.

also TextField's style is outside the scope of this library. It's inside the scope of your App, you can customize it to show numbers Farsi by changing it's font. real digits but in Farsi

here is an example

photo_2019-01-17_06-42-04

About the source, I forgot to upload it here. I will, tonight or tomorrow

@Ali-Azmoud
Copy link
Owner

You know, I'm going to give it a shot tonight. I'm sure it can be done somehow :)
so I'm going to reopen this issue

@Ali-Azmoud Ali-Azmoud reopened this Jan 17, 2019
@Ali-Azmoud Ali-Azmoud added the good first issue Good for newcomers label Jan 17, 2019
@Ali-Azmoud
Copy link
Owner

it's done. you can now get Farsi digits inside your TextField as well

@DanialV
Copy link
Author

DanialV commented Jan 19, 2019

thanks, it is awesome now and thanks again for your great support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants