Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation is probably not a toolbar #13

Open
diegohaz opened this issue Sep 8, 2020 · 0 comments
Open

Navigation is probably not a toolbar #13

diegohaz opened this issue Sep 8, 2020 · 0 comments

Comments

@diegohaz
Copy link

diegohaz commented Sep 8, 2020

Hi Ali!

I noticed that you're using the Reakit Toolbar to create what looks like a navigation bar. It depends on the context of course, but most of the time it's not semantically correct. You would be better using the <nav> element so screen reader users could easily find it using things like the VoiceOver Rotor.

It's also more SEO-friendly. 😆

The Toolbar component is more suitable for app-like toolbars, like this one:

Screenshot of the GitHub issue form with a toolbar above

It's a very common misconception though. Reakit docs should be more clear about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant