Skip to content

Commit

Permalink
fix(type/service-response): default generics
Browse files Browse the repository at this point in the history
Co-authored-by: Mohammad Honarvar <honarvar.info@gmail.com>
  • Loading branch information
AliMD and mohammadhonarvar committed Mar 18, 2023
1 parent c11cb05 commit 04dfe54
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions core/type/src/service-response.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ export interface AlwatrServiceResponseFailed extends StringifyableRecord {
data?: never;
}

export interface AlwatrServiceResponseSuccess<TData extends StringifyableRecord> extends StringifyableRecord {
export interface AlwatrServiceResponseSuccess<TData extends StringifyableRecord = StringifyableRecord>
extends StringifyableRecord {
ok: true;
statusCode?: number;
errorCode?: never;
Expand All @@ -23,8 +24,8 @@ export interface AlwatrServiceResponseSuccess<TData extends StringifyableRecord>
}

export interface AlwatrServiceResponseSuccessWithMeta<
TData extends StringifyableRecord,
TMeta extends StringifyableRecord
TData extends StringifyableRecord = StringifyableRecord,
TMeta extends StringifyableRecord = StringifyableRecord
> extends StringifyableRecord {
ok: true;
statusCode?: number;
Expand All @@ -33,7 +34,10 @@ export interface AlwatrServiceResponseSuccessWithMeta<
data: TData;
}

export type AlwatrServiceResponse<TData extends StringifyableRecord, TMeta extends StringifyableRecord> =
export type AlwatrServiceResponse<
TData extends StringifyableRecord = StringifyableRecord,
TMeta extends StringifyableRecord = StringifyableRecord
> =
| AlwatrServiceResponseSuccess<TData>
| AlwatrServiceResponseSuccessWithMeta<TData, TMeta>
| AlwatrServiceResponseFailed;

0 comments on commit 04dfe54

Please sign in to comment.