Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui-kit/button): use button content property #966

Closed
wants to merge 22 commits into from
Closed

refactor(ui-kit/button): use button content property #966

wants to merge 22 commits into from

Conversation

njfamirm
Copy link
Contributor

!

@njfamirm njfamirm added enhancement Enhancement of the code, not introducing new features. breaking-change A change that changes the API or breaks backward compatibility for users. labels Mar 19, 2023
@njfamirm njfamirm added this to the v0.x milestone Mar 19, 2023
@njfamirm njfamirm requested a review from AliMD as a code owner March 19, 2023 15:21
@njfamirm njfamirm self-assigned this Mar 19, 2023
@njfamirm njfamirm force-pushed the feat/button branch 3 times, most recently from 9f76e8d to 27e9919 Compare March 19, 2023 16:45
@AliMD AliMD changed the base branch from next to feat/com-order-detail March 22, 2023 13:17
njfamirm and others added 17 commits March 23, 2023 20:02
@njfamirm
refactor(ui-kit/button): use button content property
75d7391
@njfamirm
feat: use button content
1e58e06
@AliMD @njfamirm
refactor(ui/button): render template and reflect attribs
aac6d20
@njfamirm
refactor(ui-kit/button): check click signal id on click handler
b7d57a1
@njfamirm
refactor(ui-kit/icon-button): render template and reflect attributes
944496f
@njfamirm
refactor(com-pwa/order-detail): move button to manager
da2d09a
@njfamirm
refactor(com-pwa/new-ordr): move button to manager
1469618
@njfamirm
fix(com-pwa/new-order-controller): scroll to top on review state
96041c7
@njfamirm
refactor(com-pwa/new-order): set label Key on button content
8894dc6
@njfamirm
perf(ui-kit/top-app-bar): check attribute value before set it
7092cd3
@njfamirm
perf(ui-kit): set attribute on firstUpdated
ca9b1cc
@njfamirm
perf(ui-kit): render on null content property
fda027a
@njfamirm
refactor(ui-kit): set default content value
929aee0
@njfamirm
feat(ui-kit/text-field): use content property
4e813a6
@njfamirm
feat: use content for text field
1b74a6c
@njfamirm
feat(ui-kit/radio-group): use content property
5c94a36
@njfamirm
feat: use content for radio group
7b5e2ab
@njfamirm njfamirm closed this Mar 24, 2023
@njfamirm
Copy link
Contributor Author

باشه مرتبش میکنم توی برنچ های دیگه

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AliMD AliMD AliMD left review comments

Assignees

@njfamirm njfamirm

Labels
breaking-change A change that changes the API or breaks backward compatibility for users. enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
v0.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@njfamirm @AliMD