Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve fails with Swift 4 #173

Closed
danielsaidi opened this issue Sep 6, 2017 · 1 comment
Closed

resolve fails with Swift 4 #173

danielsaidi opened this issue Sep 6, 2017 · 1 comment

Comments

@danielsaidi
Copy link

danielsaidi commented Sep 6, 2017

I just created a brand new project in Xcode , then added Dip as one of the first external pods. The project won't build, since Dip fails with the following error:

Extraneous argument label 'tag:' in call

It occurs in RuntimeArguments when Dip runs resolve(tag: tag).

I forked and opened the project locally. It builds correctly at first, but after migrating to Swift 4, I get the same errors as I got when adding the 5.1 pod with CocoaPods.

I have created a pull request that solves these errors (although perhaps the fixes are incorrect...you decide) but when I do, I am stuck with the same register error as is reported in another issue.

@danielsaidi
Copy link
Author

I have forked Dip and added Swift 4 migrations and fixes for bugs that appeared as a result of the migration.

After migrating, the register problem (https://github.com/AliSoftware/Dip/issues/172) appeared, which I fixed with https://gist.github.com/Arasthel/38434fccf17e78fcf370f4724d86c2ff.

I have verified that these fixes work in the project I'm working with, at least to resolve with zero arguments. The pull request also fixes #172

@danielsaidi danielsaidi mentioned this issue Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants