Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export OHHTTPStubs from OHHTTPStubsSwift #353

Merged
merged 2 commits into from Jan 11, 2024

Conversation

manicmaniac
Copy link
Contributor

@manicmaniac manicmaniac commented Oct 26, 2022

Checklist

  • I've checked that all new and existing tests pass
  • I've updated the documentation if necessary
  • I've added an entry in the CHANGELOG to credit myself

Description

Export OHHTTPStubs from OHHTTPStubsSwift using @_exported so that users doesn't need to import both of them.

Motivation and Context

Previously SwiftPM users should import both OHHTTPStubs and OHHTTPStubsSwift, contrary to CocoaPods users who need to import only OHHTTPStubs.
This difference is small but an obstacle for migrating to Swift Package Manager.

  1. Firstly I removed import OHHTTPStubs statement from Tests/OHHTTPStubsSwiftTests/SwiftHelperTests.swift. This change made tests fail.
  2. Then add @_exported modifier to import statement, then the test passed.

@AliSoftware AliSoftware merged commit a25118a into AliSoftware:master Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants