New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long links wrapping option #86
Conversation
New option --no-wrap-links Basic link ignore added.
for now. Updated docs.
Conflicts: docs/usage.md html2text/__init__.py html2text/cli.py
Great work, @theSage21 please update the readme.md with the latest changes regarding to options. |
@Alir3z4 I feel the readme is getting long. The option has been added in the relevant docs section. Should i still add? |
@theSage21 I feel the same way, but we can't leave it to be out-dated.One solution would be removing the options/flags from readme me and just mention the the related doc in the readme file, what do you think ? If you're agree you can leave it out here and remove the options/flags section in another pull-request. |
@Alir3z4 Lets mention in the readme that all options are available in the docs and keep one option for demonstration. |
@Alir3z4 I will leave it as it is here. For clarity I will create another PR which has the required changes. |
Without |
The implied |
@stefanor On second thought, what if someone wants in-line links but not wrapped? The kind you get with just |
The thing is that it's not just the link you're not wrapping, it's the rest of the paragraph. Having the paragraph not be wrapped just because it has a link in the middle of it is weird. |
Changelog update Conflicts: docs/usage.md
True. |
@Alir3z4 I removed the CLI options from README and pointed them to the docs. You can merge now. |
Long links wrapping option Thanks @theSage21
@theSage21 @stefanor Thanks for the great job. |
Possible fix for #38
--no-wrap-links
has been added.