Adding functionality for Full Currency Name look up #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This JSON file contains that key/value pair of Currency short label -> Full name eg. "USD" : "United States Dollar"
Accidentally had whitespace in some of the Key values :( whoops
This adds new get_name() method, which will lookup the currency value and give back the full name of the currency. For example, give it "USD" and it returns "United States Dollar"
|
Oh additionally, this is my first time contributing to a project so I'm not 100% sure I've done the fork/merge etc etc right Please excuse anything I've missed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of your pull request?
As per Issue: #12
To add functionality to the main class whereby you can get the full currency name.
Important
Useage
from currencies import Currency
currency = Currency('USD')
currency.getname()
>>> 'United States Dollar'
Other Info
Resolves #12 which can be closed now