fix: android 10 permissions #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `mkdir` causing permission denied inside of the Discord app by patching manifest that does the following * changes `targetSdkVersion` to 28 * adds `requestLegacyExternalStorage` flag
rushiiMachine
requested changes
Oct 11, 2022
app/src/main/kotlin/com/aliucord/manager/installer/util/ManifestPatcher.kt
Outdated
Show resolved
Hide resolved
rushiiMachine
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
mkdircausing permission denied inside of the Discord app by patching manifest that does the followingtargetSdkVersionto 28requestLegacyExternalStorageflagThis shouldn't affect other android versions, <= A9 already has this behavior afaik and A11 ignores requestLegacyExternalStorage.