Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stdout sink / support promtail #181

Closed
varac opened this issue Mar 12, 2021 · 4 comments
Closed

Add stdout sink / support promtail #181

varac opened this issue Mar 12, 2021 · 4 comments

Comments

@varac
Copy link

varac commented Mar 12, 2021

We're using promtail to aggregate logs so a sinple stdout sink would be perfect for promtail to gather the
kube-eventer logs - or do they already show up in the pod stdout log ?

@varac varac changed the title Add stdout sink Add stdout sink / support promtail Mar 12, 2021
@ringtail
Copy link
Member

We're using promtail to aggregate logs so a sinple stdout sink would be perfect for promtail to gather the
kube-eventer logs - or do they already show up in the pod stdout log ?

I think a seperate log file would be better

@varac
Copy link
Author

varac commented Mar 22, 2021

from https://12factor.net/logs:

A twelve-factor app never concerns itself with routing or storage of its output stream. It should not attempt to write to or manage logfiles. Instead, each running process writes its event stream, unbuffered, to stdout

@varac
Copy link
Author

varac commented Mar 22, 2021

@ringtail Why do you think a logfile is better ? Promtail could handle both log files and stdout, so I don't care too much at the end.

@ringtail
Copy link
Member

ringtail commented Apr 7, 2021

@ringtail Why do you think a logfile is better ? Promtail could handle both log files and stdout, so I don't care too much at the end.

I agree with you. Would you like to open a pr?

@ringtail ringtail closed this as completed May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants