Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpleusb-tune-menu COS Output Logic #329

Open
tsawyer opened this issue May 16, 2024 · 5 comments · May be fixed by #356
Open

Simpleusb-tune-menu COS Output Logic #329

tsawyer opened this issue May 16, 2024 · 5 comments · May be fixed by #356
Assignees
@KB4MDD

Comments

@tsawyer
Copy link
Member

tsawyer commented May 16, 2024

From the simple-tune-menu when both COR Input and CTCSS Input are set to Off COS Output is Keyed. If an input is off it should have no role determining COS Output which should be Clear by default. A USB device must be connected to duplicate this issue. Both a URI and a RA42M exhibit this behavior.

Please enter your selection now: v
Receiver/Transmitter Status Display:
  COS   | CTCSS  | COS   | PTT
 Input  | Input  | Out   | Out
 Off    | Off    | Keyed | Keyed
@KB4MDD
Copy link
Collaborator

KB4MDD commented May 17, 2024

The COS Output is derived from an internal variable maintained by the channel driver. Apparently, this issue existed before these changes (I did not update the 'rxkeyed' variable').

Is there a case where we turn off COS input and CTCSS input? (No one could ever key the repeater.)

@tsawyer
Copy link
Member Author

tsawyer commented May 18, 2024

Both off is a good test to see if the logic is correct. It's showing that inputs are not ignored when off. In any case, I wouldn't think both off should set COS Output keyed.

There is a real-world need to have the cos off and ctcss active. It shows the sensitivity and coast of ctcss.

This on the "Stable" release indicating that it not need be fixed for the first beta.

@tsawyer
Copy link
Member Author

tsawyer commented May 18, 2024

... (No one could ever key the repeater.)

More concerning is the node is always keyed.

@KB4MDD
Copy link
Collaborator

KB4MDD commented May 18, 2024

Unfortunately this was how the driver was coded. The author never expected that both would be disabled. This should be easy to fix

@tsawyer
Copy link
Member Author

tsawyer commented May 19, 2024

Ok, please fix. No hurry on this.

KB4MDD added a commit that referenced this issue Jul 12, 2024
@KB4MDD
chan_simpleusb / chan_usbradio: Modify cos operation
61d1d0e 
chan_simpleusb and chan_usbradio should not activate the receiver
when the carrierfrom and ctcssfrom are set to no.

This closes #329.
@KB4MDD KB4MDD linked a pull request Jul 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KB4MDD KB4MDD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chan_simpleusb / chan_usbradio: Modify cos operation AllStarLink/app_rpt
2 participants
@tsawyer @KB4MDD