Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solar Neutron Activator does not work in AllTheModium Mining Dimension #388

Closed
Sadumon opened this issue Nov 24, 2020 · 8 comments
Closed
Assignees
Labels
Bug Something isn't working Mod Issue This issue is caused a mod, not us. Reported Issue has been reported to mod devs

Comments

@Sadumon
Copy link

Sadumon commented Nov 24, 2020

Describe the bug
Mekanism's Solar Neutron Activator does not work in the AllTheModium Mining Dimension

To Reproduce
Build a Solar Neutron Activator, place it in the mining dimension, and put nuclear waste or deuterium into it...nothing happens.

Expected behavior
As it's an always sunny dimension, it should function.

Additional context
My guess is that one of these checks is failing:
boolean seesSun = world.isDaytime() && world.canBlockSeeSky(pos.up()) && world.getDimensionType().hasSkyLight();

@Sadumon Sadumon added the Bug Something isn't working label Nov 24, 2020
@RedDragonRob
Copy link

Having Similar Problems with Powah Solar Panels in the Mining Dim as well. Does nothing, but place in Overworld or The Other dimensions and it works fine.

@thevortex
Copy link
Contributor

that is very odd, you say it works in 'The Other' ? there is never daytime there....

@RedDragonRob
Copy link

Yeap, and working at night in overworld, at least niotic solar is.

@D3s0l4ti0n
Copy link

submitted a bug on mekanism page they said the dimension may not be registering that it has daylight but it is daytime

mekanism/Mekanism#6801

@Nonsanity
Copy link

Looks like the AllTheModium mod needs to set its mining dimension's hasSkyLight to true.

It's problematic to set up the Solar Neutron Activator there and fill it with nuclear waste only to find it won't work there at all. Breaking pipes and blocks with nuclear waste in them will irradiate the whole area. There's no way to get the stuff out of the machine except to run it, and that's not possible without that flag set on the dimension.

@thevortex
Copy link
Contributor

here is the dimension data file


 {

  "name": "allthemodium:mining",
  "type": "allthemodium:mining",
  "ultrawarm": false,
  "natural": false,
  "fixed_time": 9000,
  "shrunk": false,
  "piglin_safe": true,
  "respawn_anchor_works": false,
  "bed_works": true,
  "has_raids": false,
  "has_skylight": true,
  "has_ceiling": false,
  "ambient_light": 0.75,
  "logical_height": 256,
  "infiniburn": "minecraft:infiniburn_overworld",
  "coordinate_scale": 1
}

looks like it is,

@jeremiahwinsley jeremiahwinsley added Mod Issue This issue is caused a mod, not us. Reported Issue has been reported to mod devs labels Jan 10, 2021
@Dunkmania101
Copy link

I think I found the issue! It's the same thing that's been happening in my Daylight Dimension mod. I was looking at the isDaytime method and saw that it returns false if the fixed time value is set. How annoying! I think I'll remove that value from the json file and create an event subscriber that sets the time in my dimension to noon every tick.

@PP-FT
Copy link

PP-FT commented May 28, 2021

How do I get to the dimension data file? I don't see it in datapacks in the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Mod Issue This issue is caused a mod, not us. Reported Issue has been reported to mod devs
Projects
None yet
Development

No branches or pull requests

9 participants