Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CRC8 for cnfLine message #311

Closed
dl1com opened this issue Jun 9, 2020 · 1 comment · Fixed by #323
Closed

Implement CRC8 for cnfLine message #311

dl1com opened this issue Jun 9, 2020 · 1 comment · Fixed by #323
Assignees
@t0mpr1c3
Labels
enhancement ready - please test
Milestone
1.0.0

Comments

@dl1com
Copy link
Contributor

dl1com commented Jun 9, 2020

add a CRC8 on bytes 0-28 of the cnfLine message, so the Arduino can check if the line data is correct and re-request in case of failure (https://github.com/AllYarnsAreBeautiful/ayab-firmware/blob/v1.0-dev/src/ayab/serial_encoding.cpp#L129)
@dl1com dl1com added this to the 1.0.0 milestone Jun 9, 2020
@t0mpr1c3 t0mpr1c3 mentioned this issue Jun 12, 2020
Merged
@t0mpr1c3 t0mpr1c3 self-assigned this Jun 12, 2020
@dl1com dl1com linked a pull request Jun 14, 2020 that will close this issue
CRC8 check #323
Merged
@dl1com
Copy link
Contributor Author

dl1com commented Jun 15, 2023

Implementation is done, closing.

@dl1com dl1com closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0mpr1c3 t0mpr1c3

Labels
enhancement ready - please test
Projects
AYAB 1.0.0 Release Tracking
Status: Done
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

CRC8 check t0mpr1c3/ayab-desktop
2 participants
@dl1com @t0mpr1c3