-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for geomtextpath #1
Comments
Hi Allan, This is great, nice to see the readme got updated with clear examples and such!
We might be able to use the {vdiffr} package for testing visual output. But we might include some more basic tests to validate that individual components (helper functions) are working and then use a visual test to see that everything integrates as intended.
If the main function is text on a path, it would be quite easy to extend it to the case of
I agree, it would be nice if we would have a guide for this along with a
At some point when we're happy with the code, we might submit the repo to the ggplot2 extension gallery, which hopefully triggers a few people to test and report back any problems they experience. Additionally, we might post about it in a blog post or on twitter to increase visibility. I don't think we should defensively code against all edge cases, just the ones you might reasonably run into.
I don't know this for sure either, but lets say when we're both happy with how everything works, have got automated checks in place, we've let people play with the functions and given some time to report any problems? We might also still write a vignette or build a pkgdown site for people to visit. I'll have a more detailed look of the code later in the day! |
This thread was to discuss details of the initial commit and anticipate problems early-on. Specific issues have now been moved to the appropriate thread to keep development focused on these. |
The initial version of geomtextpath with rudimentary docs and functionality is here! This version passes CRAN checks.
I have put copious comments in the code, including a couple of TODO sections that might be good places to start.
There are a few thoughts that occurred to me that we might wish to consider.
The text was updated successfully, but these errors were encountered: