Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel children from activity coroutines instead of job itself #214

Closed
AllanWang opened this issue Jun 29, 2019 · 1 comment
Closed

Cancel children from activity coroutines instead of job itself #214

AllanWang opened this issue Jun 29, 2019 · 1 comment

Comments

@AllanWang
Copy link
Owner

https://proandroiddev.com/kotlin-coroutines-patterns-anti-patterns-f9d12984c68e

Perhaps add base fragment? Coroutines also has MainScope now so I'm not sure if we should delegate to that too
@AllanWang
Copy link
Owner Author

We're not reusing jobs so it seems better to cancel the job itself. Otherwise users can still submit jobs when an activity is destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AllanWang