Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lint action to pre-commit.ci #348

Closed
ianhi opened this issue Nov 4, 2021 · 2 comments
Closed

Move lint action to pre-commit.ci #348

ianhi opened this issue Nov 4, 2021 · 2 comments
Labels
admin Various administrative tasks for the package documentation Improvements or additions to documentation enhancement New feature or request Stale
Projects

Comments

@ianhi
Copy link
Contributor

ianhi commented Nov 4, 2021

Instead of having lint issues discovered via the github action for linting, fixed locally, and then the lint action running again I propose removing the lint section of the github action and setting up a https://pre-commit.ci/ integration. This way contributors never have to worry about linting (although they can install pre-commit hooks locally if they want) as a bot will push fixes to any lint failures automatically.

@evamaxfield evamaxfield added admin Various administrative tasks for the package documentation Improvements or additions to documentation enhancement New feature or request labels Nov 4, 2021
@evamaxfield evamaxfield added this to To do in Admin via automation Nov 4, 2021
@evamaxfield
Copy link
Collaborator

Haven't in the past simply because this project was mostly just AICS people but as more people contribute I think I agree this is a good model.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Mar 29, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2023
Admin automation moved this from To do to Done Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Various administrative tasks for the package documentation Improvements or additions to documentation enhancement New feature or request Stale
Projects
Admin
  
Done
Development

No branches or pull requests

2 participants