bugfix/catch-invalid-XMLAnnotationID

[tlambert03]

Description

fixes #454

This PR is sufficient to get the xml/h5 dataset linked in the original issue reading with the bioformats reader... (and lets me think a bit longer about how I want to handle invalid schemas over in ome-types)

Pull request recommendations:

• Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
• Link to any relevant issue in the PR description. Ex: Resolves [gh-], adds tiff file format support
• Provide relevant tests for your feature or bug fix.
• Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

[codecov-commenter]

Codecov Report

Base: 94.00% // Head: 93.91% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (9adc76b) compared to base (b9925b3).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   94.00%   93.91%   -0.10%     
==========================================
  Files          46       46              
  Lines        4021     4027       +6     
==========================================
+ Hits         3780     3782       +2     
- Misses        241      245       +4     

Impacted Files	Coverage Δ
aicsimageio/metadata/utils.py	88.62% <33.33%> (-1.62%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[AetherUnbound]

Looks good! Are there any tests we could add for this?

[evamaxfield]

Looks good to me!

[evamaxfield]

@AetherUnbound I am okay without new test data being added. Is that a hard req from you or okay to merge?

[tlambert03]

I could also mock some fake data without a file.

I also fixed/test this in ome types tlambert03/ome-types#159

[toloudis]

Not to confuse things, but should we just update ome-types min version and call it good? (No objection from me either way)

[AetherUnbound]

Nope! Not a dealbreaker, just thought I'd mention in case it was an easy thing to throw in 🙂

[evamaxfield]

Not to confuse things, but should we just update ome-types min version and call it good? (No objection from me either way)

We will have to wait for @tlambert03's answer but I agree. If there is no difference between the two then why not?

[tlambert03]

That works for me too! Let me also try to test in on windows, since the original poster reported there might still be an issue

[SeanLeRoy]

Does this seem good to merge? @tlambert03

[tlambert03]

actually, I think you can just close this ... it should have been fixed by tlambert03/ome-types#159 which has since been released in ome-types v0.3.3

[tlambert03]

I'll go ahead and do that for you :) if it comes up again feel free to ping me