Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider checking Cargo.toml back into git #8

Closed
expenses opened this issue May 1, 2023 · 2 comments
Closed

Consider checking Cargo.toml back into git #8

expenses opened this issue May 1, 2023 · 2 comments

Comments

@expenses
Copy link

expenses commented May 1, 2023

Hi! #6 for rid of the Cargo.lock file. It's totally up to you, but I've found that having Cargo.lock committed for binary projects has been very useful for stability and debugging. It's recommended by the cargo guide as well: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries. I'd consider checking it back into git. (@adsick).

@AllenDang
Copy link
Owner

@expenses Agreed, i will add it back

@AllenDang
Copy link
Owner

I got this comment, maybe Cargo.lock should be ignored?

Remove Cargo.lock from gitignore if creating an executable, leave it for libraries

More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants