Update chap02 #32
Merged
Update chap02 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first line edited is self explanatory, that is a typo. If we create a sawtooth signal, we should say "sawtooth" instead of "triangle" The second edit is needed, since the spectrum that we are modifying is from line 440, which is before creating the new sawtooth signal. I discovered it by making changes to duration and framerate of the sawtooth signal, and when playing the two comparative audios (with just different phases) the lenghts of the audios were completely different.
|
Thank you! |
|
Thanks to you for your letting me think dsp ;) |
|
@AllenDowney Hello, thanks for sharing the great material! |
|
Yes, they have the same amplitude at every frequency, but different phases.
If you are interested, I gave a talk about this exercise: https://www.dsprelated.com/showarticle/1419.php
…On Fri, Sep 2, 2022, at 11:20 AM, JaejinCho wrote:
@AllenDowney <https://github.com/AllenDowney> Hello, thanks for sharing the great material!
I was curious why two different approaches in exercise 5 in chap02soln resulted in different-looking waves. (Is this somehow related to phase?)
—
Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOLP3NFEA63LN4OMHLUPBLV4ILNVANCNFSM4DLRAGFQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Thank you @AllenDowney for the great pointer. I understood better after watching the video! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first line edited is self explanatory, that is a typo. If we create a sawtooth signal, we should say "sawtooth" instead of "triangle"
The second edit is needed, since the spectrum that we are modifying is from line 440, which is before creating the new sawtooth signal.
I discovered it by making changes to duration and framerate of the sawtooth signal, and when playing the two comparative audios (with just different phases) the lenghts of the audios were completely different.