Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options value for current page and size per page are not respected #304

Closed
xabikos opened this issue Feb 29, 2016 · 9 comments
Closed

Options value for current page and size per page are not respected #304

xabikos opened this issue Feb 29, 2016 · 9 comments
Labels

Comments

@xabikos
Copy link

xabikos commented Feb 29, 2016

We are using the component with server side pagination. This means that we only retrieve the data for the current page from the page and in every page change or when the size of the page changes a new request is happening. This requires to maintain the current page and the current size per page internally and pass it to react-bootstrap-table through the options object. This worked quite good but currently is broken. I suspect this happened in this commit as I noticed this behavior in version 1.5.3. If the description is not clear enough I can provide also a small example demonstrate that.

@AllenFang
Copy link
Owner

@xabikos, I thinks a example is good.

@xabikos
Copy link
Author

xabikos commented Mar 8, 2016

@AllenFang Here you can find an example gist I created which demonstrates the problem
https://gist.github.com/xabikos/fcd6e709f8ae0c11e33b
This works perfectly in version 1.5.2 but not in later versions. Paging and size per page are not changed in a correct way. Please let me know if I need to provide some more info.

@AllenFang
Copy link
Owner

Thank you! I'll check this out

@xabikos
Copy link
Author

xabikos commented Mar 8, 2016

Please keep in mind my first comment and which changes are probably related to the problem. Thanks in advance for the help. I will also try to explore the code.

@AllenFang
Copy link
Owner

@xabikos, a question, the problem which you encounter is that the page button and sizePerPage dropdown is not changed correctly? ex: click page 2, but I see page one still clicked but data has changed correctly

@xabikos
Copy link
Author

xabikos commented Mar 8, 2016

Exactly this one. And if you try to change the size per page e.g. to 25 then you will see 25 rows but the corresponding dropdown still shows 10

@AllenFang AllenFang added the bug label Mar 8, 2016
@AllenFang
Copy link
Owner

ok, Thanks your example!

@AllenFang
Copy link
Owner

@xabikos, fixed on v1.6.2. You can check it out :)

@xabikos
Copy link
Author

xabikos commented Apr 4, 2016

Yes it is fixed. Thanks once again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants