Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inference: accept path or dict #55

Open
2 tasks
djkapner opened this issue May 1, 2021 · 1 comment
Open
2 tasks

inference: accept path or dict #55

djkapner opened this issue May 1, 2021 · 1 comment

Comments

@djkapner
Copy link
Contributor

djkapner commented May 1, 2021

the API layer reads and validates arguments. It currently must then write those to disk so the inference class can get a path as an argument.
It would be preferable to send the args to the inference class in memory.

Tasks:

  • change inference class to accept either a path to a json, or a dictionary.
  • change the inference API layer to pass a dictionary.
@jeromelecoq
Copy link
Collaborator

We just deployed the CLI at a broader scale to fix this. My plan is to transition all users to the CLI so that we can remove this behavior without impacting anyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants