Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SMALLFIX] Fix the logging message in ReplicationChecker #15043

Open
wants to merge 1 commit into
base: master-2.x
Choose a base branch
from
Open

[SMALLFIX] Fix the logging message in ReplicationChecker #15043

wants to merge 1 commit into from

Conversation

JackWangCS
Copy link

@JackWangCS JackWangCS commented Feb 23, 2022 •
edited

What changes are proposed in this pull request?

Fixes Alluxio/Community#636.

Fix the logging message in ReplicationChecker.

Why are the changes needed?

Improve logging

Does this PR introduce any user facing changes?

No

@alluxio-bot
Copy link
Contributor

Hi @JackWangCS, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • Commits associated with Github account: FAIL
    • It looks like your commits can't be linked to a valid Github account.
      Your commits are made with the email jie.wang@hulu.com, which does not allow your contribution to be tracked by Github.
      See this link for possible reasons this might be happening.
      To change the author email address that your most recent commit was made under, you can run: 
      git -c user.name="Name" -c user.email="Email" commit --amend --reset-author
      See this answer for more details about how to change commit email addresses.
      Once the author email address has been updated, update the pull request by running: 
      git push --force https://github.com/JackWangCS/alluxio.git new-contributor-tasks-636
  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • First word of title ("Fixes") is not an imperative verb. Please use one of the valid words

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

@alluxio-bot
Copy link
Contributor

You did it @JackWangCS!

Thank you for signing the Contribution License Agreement.

@JackWangCS JackWangCS changed the title Fixes Alluxio/new-contributor-tasks#636 [SMALLFIX] Fixes the logging message in ReplicationChecker Feb 23, 2022
@JackWangCS JackWangCS changed the title [SMALLFIX] Fixes the logging message in ReplicationChecker [SMALLFIX] Fix the logging message in ReplicationChecker Feb 23, 2022
jiacheliu3
jiacheliu3 approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@jiacheliu3 jiacheliu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@jiacheliu3
Copy link
Contributor

Failed tests are irrelevant to the change

Error: 0.271 [ERROR] alluxio.server.ft.journal.raft.EmbeddedJournalIntegrationTestTransferLeadership.repeatedTransferLeadership
Error: 0.272 [ERROR]   Run 1: EmbeddedJournalIntegrationTestTransferLeadership.repeatedTransferLeadership:75->transferAndWait:250->EmbeddedJournalIntegrationTestBase.waitForQuorumPropertySize:58 » Timeout
Error: 0.272 [ERROR]   Run 2: EmbeddedJournalIntegrationTestTransferLeadership.repeatedTransferLeadership:75->transferAndWait:250->EmbeddedJournalIntegrationTestBase.waitForQuorumPropertySize:58 » Timeout

Error: 2.373 [ERROR] Failures: 
Error: 2.373 [ERROR] alluxio.client.fs.BlockMasterRegisterStreamIntegrationTest.hangingWorkerSessionRecycled
Error: 2.376 [ERROR]   Run 1: BlockMasterRegisterStreamIntegrationTest.hangingWorkerSessionRecycled:409->verifyWorkerCanReregister:860 expected:<0> but was:<7>
Error: 2.376 [ERROR]   Run 2: BlockMasterRegisterStreamIntegrationTest.hangingWorkerSessionRecycled:409->verifyWorkerCanReregister:860 expected:<0> but was:<5>

Error: 7.813 [ERROR] alluxio.client.cli.JournalToolTest.dumpHeapCheckpointFromEmbeddedJournal  Time elapsed: 60.402 s  <<< ERROR!
java.lang.RuntimeException: java.lang.RuntimeException: Timed out waiting for process Alluxio worker @b4c38962060e:0 to start
	at alluxio.testutils.LocalAlluxioClusterResource$1.evaluate(LocalAlluxioClusterResource.java:195)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.RuntimeException: Timed out waiting for process Alluxio worker @b4c38962060e:0 to start
	at alluxio.master.TestUtils.waitForReady(TestUtils.java:34)
	at alluxio.master.AbstractLocalAlluxioCluster.startWorkers(AbstractLocalAlluxioCluster.java:160)
	at alluxio.master.AbstractLocalAlluxioCluster.start(AbstractLocalAlluxioCluster.java:88)
	at alluxio.testutils.LocalAlluxioClusterResource.start(LocalAlluxioClusterResource.java:157)
	at alluxio.testutils.LocalAlluxioClusterResource$1.evaluate(LocalAlluxioClusterResource.java:192)
	... 5 more

Error: 7.839 [ERROR] alluxio.client.cli.JournalToolTest.dumpHeapCheckpointFromEmbeddedJournal  Time elapsed: 60.422 s  <<< ERROR!
java.lang.RuntimeException: java.lang.RuntimeException: Timed out waiting for process Alluxio worker @b4c38962060e:0 to start
	at alluxio.testutils.LocalAlluxioClusterResource$1.evaluate(LocalAlluxioClusterResource.java:195)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.RuntimeException: Timed out waiting for process Alluxio worker @b4c38962060e:0 to start
	at alluxio.master.TestUtils.waitForReady(TestUtils.java:34)
	at alluxio.master.AbstractLocalAlluxioCluster.startWorkers(AbstractLocalAlluxioCluster.java:160)
	at alluxio.master.AbstractLocalAlluxioCluster.start(AbstractLocalAlluxioCluster.java:88)
	at alluxio.testutils.LocalAlluxioClusterResource.start(LocalAlluxioClusterResource.java:157)
	at alluxio.testutils.LocalAlluxioClusterResource$1.evaluate(LocalAlluxioClusterResource.java:192)
	... 5 more

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The PR/Issue does not have recent activities and will be closed automatically label Jan 28, 2023
@github-actions github-actions bot removed the stale The PR/Issue does not have recent activities and will be closed automatically label May 16, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The PR/Issue does not have recent activities and will be closed automatically label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacheliu3 jiacheliu3 jiacheliu3 approved these changes

Assignees

@ggezer ggezer

Labels
stale The PR/Issue does not have recent activities and will be closed automatically
Projects
None yet
Milestone
No milestone
4 participants
@JackWangCS @alluxio-bot @jiacheliu3 @ggezer