Skip to content

Commit

Permalink
Use static imports for standard test utilities
Browse files Browse the repository at this point in the history 
修改了static import
将Assert.删除

pr-link: #9069
change-id: cid-be399ab69bf552a04bde055bbcf3608960f03fc0
  • Loading branch information
@Notteaquail @alluxio-bot
Notteaquail authored and alluxio-bot committed May 14, 2019
1 parent 60b1ac6 commit be27459
Showing 1 changed file with 50 additions and 49 deletions.
99 changes: 50 additions & 49 deletions core/common/src/test/java/alluxio/security/authorization/ModeParserTest.java
View file
Expand Up @@ -11,9 +11,10 @@


package alluxio.security.authorization; package alluxio.security.authorization;


import static org.junit.Assert.assertEquals;

import alluxio.exception.ExceptionMessage; import alluxio.exception.ExceptionMessage;


import org.junit.Assert;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.rules.ExpectedException; import org.junit.rules.ExpectedException;
Expand All @@ -34,96 +35,96 @@ public final class ModeParserTest {
@Test @Test
public void numerics() { public void numerics() {
Mode parsed = ModeParser.parse("777"); Mode parsed = ModeParser.parse("777");
Assert.assertEquals(Mode.Bits.ALL, parsed.getOwnerBits()); assertEquals(Mode.Bits.ALL, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.ALL, parsed.getGroupBits()); assertEquals(Mode.Bits.ALL, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.ALL, parsed.getOtherBits()); assertEquals(Mode.Bits.ALL, parsed.getOtherBits());


parsed = ModeParser.parse("755"); parsed = ModeParser.parse("755");
Assert.assertEquals(Mode.Bits.ALL, parsed.getOwnerBits()); assertEquals(Mode.Bits.ALL, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.READ_EXECUTE, parsed.getGroupBits()); assertEquals(Mode.Bits.READ_EXECUTE, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.READ_EXECUTE, parsed.getOtherBits()); assertEquals(Mode.Bits.READ_EXECUTE, parsed.getOtherBits());


parsed = ModeParser.parse("644"); parsed = ModeParser.parse("644");
Assert.assertEquals(Mode.Bits.READ_WRITE, parsed.getOwnerBits()); assertEquals(Mode.Bits.READ_WRITE, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.READ, parsed.getGroupBits()); assertEquals(Mode.Bits.READ, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.READ, parsed.getOtherBits()); assertEquals(Mode.Bits.READ, parsed.getOtherBits());
} }


@Test @Test
public void symbolicsSeparated() { public void symbolicsSeparated() {
Mode parsed = ModeParser.parse("u=rwx,g=rwx,o=rwx"); Mode parsed = ModeParser.parse("u=rwx,g=rwx,o=rwx");
Assert.assertEquals(Mode.Bits.ALL, parsed.getOwnerBits()); assertEquals(Mode.Bits.ALL, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.ALL, parsed.getGroupBits()); assertEquals(Mode.Bits.ALL, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.ALL, parsed.getOtherBits()); assertEquals(Mode.Bits.ALL, parsed.getOtherBits());


parsed = ModeParser.parse("u=rwx,g=rx,o=rx"); parsed = ModeParser.parse("u=rwx,g=rx,o=rx");
Assert.assertEquals(Mode.Bits.ALL, parsed.getOwnerBits()); assertEquals(Mode.Bits.ALL, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.READ_EXECUTE, parsed.getGroupBits()); assertEquals(Mode.Bits.READ_EXECUTE, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.READ_EXECUTE, parsed.getOtherBits()); assertEquals(Mode.Bits.READ_EXECUTE, parsed.getOtherBits());


parsed = ModeParser.parse("u=rw,g=r,o=r"); parsed = ModeParser.parse("u=rw,g=r,o=r");
Assert.assertEquals(Mode.Bits.READ_WRITE, parsed.getOwnerBits()); assertEquals(Mode.Bits.READ_WRITE, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.READ, parsed.getGroupBits()); assertEquals(Mode.Bits.READ, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.READ, parsed.getOtherBits()); assertEquals(Mode.Bits.READ, parsed.getOtherBits());
} }


@Test @Test
public void symbolicsCombined() { public void symbolicsCombined() {
Mode parsed = ModeParser.parse("a=rwx"); Mode parsed = ModeParser.parse("a=rwx");
Assert.assertEquals(Mode.Bits.ALL, parsed.getOwnerBits()); assertEquals(Mode.Bits.ALL, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.ALL, parsed.getGroupBits()); assertEquals(Mode.Bits.ALL, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.ALL, parsed.getOtherBits()); assertEquals(Mode.Bits.ALL, parsed.getOtherBits());


parsed = ModeParser.parse("ugo=rwx"); parsed = ModeParser.parse("ugo=rwx");
Assert.assertEquals(Mode.Bits.ALL, parsed.getOwnerBits()); assertEquals(Mode.Bits.ALL, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.ALL, parsed.getGroupBits()); assertEquals(Mode.Bits.ALL, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.ALL, parsed.getOtherBits()); assertEquals(Mode.Bits.ALL, parsed.getOtherBits());


parsed = ModeParser.parse("u=rwx,go=rx"); parsed = ModeParser.parse("u=rwx,go=rx");
Assert.assertEquals(Mode.Bits.ALL, parsed.getOwnerBits()); assertEquals(Mode.Bits.ALL, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.READ_EXECUTE, parsed.getGroupBits()); assertEquals(Mode.Bits.READ_EXECUTE, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.READ_EXECUTE, parsed.getOtherBits()); assertEquals(Mode.Bits.READ_EXECUTE, parsed.getOtherBits());


parsed = ModeParser.parse("u=rw,go=r"); parsed = ModeParser.parse("u=rw,go=r");
Assert.assertEquals(Mode.Bits.READ_WRITE, parsed.getOwnerBits()); assertEquals(Mode.Bits.READ_WRITE, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.READ, parsed.getGroupBits()); assertEquals(Mode.Bits.READ, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.READ, parsed.getOtherBits()); assertEquals(Mode.Bits.READ, parsed.getOtherBits());
} }


@Test @Test
public void symbolicsCumulative() { public void symbolicsCumulative() {
Mode parsed = ModeParser.parse("u=r,u=w,u=x"); Mode parsed = ModeParser.parse("u=r,u=w,u=x");
Assert.assertEquals(Mode.Bits.ALL, parsed.getOwnerBits()); assertEquals(Mode.Bits.ALL, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.NONE, parsed.getGroupBits()); assertEquals(Mode.Bits.NONE, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.NONE, parsed.getOtherBits()); assertEquals(Mode.Bits.NONE, parsed.getOtherBits());


parsed = ModeParser.parse("g=r,g=w,g=x"); parsed = ModeParser.parse("g=r,g=w,g=x");
Assert.assertEquals(Mode.Bits.NONE, parsed.getOwnerBits()); assertEquals(Mode.Bits.NONE, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.ALL, parsed.getGroupBits()); assertEquals(Mode.Bits.ALL, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.NONE, parsed.getOtherBits()); assertEquals(Mode.Bits.NONE, parsed.getOtherBits());


parsed = ModeParser.parse("o=r,o=w,o=x"); parsed = ModeParser.parse("o=r,o=w,o=x");
Assert.assertEquals(Mode.Bits.NONE, parsed.getOwnerBits()); assertEquals(Mode.Bits.NONE, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.NONE, parsed.getGroupBits()); assertEquals(Mode.Bits.NONE, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.ALL, parsed.getOtherBits()); assertEquals(Mode.Bits.ALL, parsed.getOtherBits());
} }


@Test @Test
public void symbolicsPartial() { public void symbolicsPartial() {
Mode parsed = ModeParser.parse("u=rwx"); Mode parsed = ModeParser.parse("u=rwx");
Assert.assertEquals(Mode.Bits.ALL, parsed.getOwnerBits()); assertEquals(Mode.Bits.ALL, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.NONE, parsed.getGroupBits()); assertEquals(Mode.Bits.NONE, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.NONE, parsed.getOtherBits()); assertEquals(Mode.Bits.NONE, parsed.getOtherBits());


parsed = ModeParser.parse("go=rw"); parsed = ModeParser.parse("go=rw");
Assert.assertEquals(Mode.Bits.NONE, parsed.getOwnerBits()); assertEquals(Mode.Bits.NONE, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.READ_WRITE, parsed.getGroupBits()); assertEquals(Mode.Bits.READ_WRITE, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.READ_WRITE, parsed.getOtherBits()); assertEquals(Mode.Bits.READ_WRITE, parsed.getOtherBits());


parsed = ModeParser.parse("o=x"); parsed = ModeParser.parse("o=x");
Assert.assertEquals(Mode.Bits.NONE, parsed.getOwnerBits()); assertEquals(Mode.Bits.NONE, parsed.getOwnerBits());
Assert.assertEquals(Mode.Bits.NONE, parsed.getGroupBits()); assertEquals(Mode.Bits.NONE, parsed.getGroupBits());
Assert.assertEquals(Mode.Bits.EXECUTE, parsed.getOtherBits()); assertEquals(Mode.Bits.EXECUTE, parsed.getOtherBits());
} }


@Test @Test
Expand Down

0 comments on commit be27459

Please sign in to comment.